Closed kephale closed 1 year ago
Hi @kephale , thanks for the contribution.
I'll merge when the tests are done.
I noticed that the non-blocking functionality is not implemented yet. Let me know when you're done, and I'll trigger the github actions.
I think the tests will need to block the code until the download is done to execute it correctly.
I actually did start writing it with a downloader thread, but it looks like using the progress bar actually fixes the blocking (at least on my local machine). TBH I'm not exactly sure why that is the case.
Merging #6 (223514b) into main (7faf94d) will increase coverage by
0.39%
. The diff coverage is81.25%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 89.32% 89.71% +0.39%
==========================================
Files 4 4
Lines 206 214 +8
==========================================
+ Hits 184 192 +8
Misses 22 22
Impacted Files | Coverage Δ | |
---|---|---|
src/napari_segment_anything/utils.py | 90.90% <81.25%> (+2.90%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This PR enables the napari GUI progress bar while downloading model weights and prevents blocking during the download.
Edit: It looks like this while downloading: