search

royerlab / ultrack

Cell tracking and segmentation software
https://royerlab.github.io/ultrack
BSD 3-Clause "New" or "Revised" License
64 stars 7 forks source link

Fixed `labels_to_edges` typo #104

Closed alex-1001 closed 1 month ago

JoOkuma commented 1 month ago

cc @ilan-theodoro, any guess why the API tests are failing? They passed on #102 and this PR is a minor fix that went through our review.

ilan-theodoro commented 1 month ago

@JoOkuma It failed on an ome-zarr function. I checked, and the previous workflow run used ome-zarr==0.8.3, but this one is ome-zarr==0.9.0. This latter version was released a few days ago, so that is why.

I think the fix is easy (not the trivial one of pinning the package :laughing:) but I personally prefer to drop the dependency in favor of using iohub

JoOkuma commented 1 month ago

I'm all for using iohub, we can even make another PR so the segments are in ome-zarr format. In hindsight I should have been pro it since the beginning.