search

royerlab / ultrack

Cell tracking and segmentation software
https://royerlab.github.io/ultrack
BSD 3-Clause "New" or "Revised" License
95 stars 12 forks source link

Relaxing dependencies and moving to Hatch and Pixi #130

Closed JoOkuma closed 4 months ago

JoOkuma commented 4 months ago

@ilan-theodoro I broke your API when updating pydantic could you take a look at it? I could not figure it out, it seems a fastapi problem.

JoOkuma commented 4 months ago

I'm waiting for higra to support numpy 2.0.0, https://github.com/higra/Higra/pull/277

JoOkuma commented 4 months ago

@ilan-theodoro I changed the CLI a bit. The config could be optional; we generate a template, and they modify it.

JoOkuma commented 4 months ago

I also included additional changes to close other bugs, hehe, sorry.

JoOkuma commented 4 months ago

@ilan-theodoro could you review this PR?

ilan-theodoro commented 4 months ago

lgtm!

I just think that we need to submit an issue remembering us to update our pydantic models to 2.*, what do you think?

JoOkuma commented 4 months ago

Probably the last one, @ilan-theodoro. Do you think the Windows error is related to the "server" test? I assume it isn't because of the "terminate/join".

ilan-theodoro commented 4 months ago

@JoOkuma it was. The problem is that it got killed trying to remove a sqlite db that was open somewhere. I fixed that with an empty try-catch on the removal procedure

JoOkuma commented 4 months ago

@ilan-theodoro, thanks; we can fix it later.