Closed qin-yu closed 4 months ago
Attention: Patch coverage is 71.42857%
with 2 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
main@09807e8
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
ultrack/core/export/trackmate.py | 71.42% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM! Thanks @qin-yu
Hey @JoOkuma,
@tischi and I encountered a small but critical and elusive bug, fixed by this PR.
Fig. 1. TrackMate. Before: no tracks | After: tracks | After: details
Fig. 2. Mastodon. After: tracks and details
The current test for exporting tracks to TrackMate solely verifies the inclusion of all spots in the output, neglecting tracking semantics. In this PR, I choose not to implement an additional test that merely converts the XML back, since the essential validation comes from the actual opening and viewing of successful tracks. I revised the function's name, though I suspect it has not been used for a while.
Before Fix
TrackMate launches with error:
Mastodon throws error only: