search

royhills / ike-scan

The IKE Scanner
GNU General Public License v3.0
361 stars 59 forks source link

Add VID Pattern Validation to CI Builds #3

Closed claudijd closed 11 years ago

claudijd commented 11 years ago

Adds a check to validate VID patterns in the source tree

If a vid pattern fails to parse, it will "break" the build.

claudijd commented 11 years ago

Now that I'm looking at this, this might be better implemented as a check file. Thoughts?

royhills commented 11 years ago

Yes, I think a check file is the best way to do this. "make check" is a standard makefile target, and that should run all the tests it can. I agree that a regex failure should be a fatal error, which will help catch these things if more people start to contribute patterns.

claudijd commented 11 years ago

I ended up reverting the behavior change I made WARN --> ERR because it was causing other checks that were unrelated to vendor ID patterns to fail. I felt it made more sense to revert back to a WARN and then just have the check verify for us. This way, if someone were to break the build with a bad vendor id pattern, it will be very clear why they build broke.