search

royhills / ike-scan

The IKE Scanner
GNU General Public License v3.0
363 stars 59 forks source link

Fix a couple autoconf tests on Xcode 12 #32

Closed mitchblank closed 3 years ago

mitchblank commented 3 years ago

Xcode 12 changed its default compile flags to include -Werror,-Wimplicit-function-declaration One place this tends to cause problems is in configure scripts where that warning may have existed for a long time without anyone noticing. Now suddenly those compile tests will fail, causing other compile problems.

In the case of ike-scan, these two tests call exit() without #include <stdlib.h>. The easiest fix, though, is to just return directly from main() so that we don't have to use exit() at all.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 77.033% when pulling c9ef0569443b03fda5339911acb8056a73c952de on mitchblank:xcode12-autoconf-fixes into 866edeae6dc11c8b45db4356f854fb6cbfe1d5ae on royhills:master.

royhills commented 3 years ago

Thanks - merged and pushed