royitaqi / HollowKnight.GodhomeWinLossTracker

A mod for the game Hollow Knight. Goal is to improve boss fight training experience in Godhome by tracking per-boss win/loss counts for Hall of Gods and pantheons.
3 stars 1 forks source link

Bug: stats tracking and display might conflict with GodSeeker+'s extra portal #26

Closed royitaqi closed 2 years ago

royitaqi commented 2 years ago

P5 and segments have the same keys. The only difference before entering the fights are the description text.

Sequence detection need something to tell that P5 and segments are different.

Current sequence detection rely on scene change, and such logic is broken by the bench before each segments.

One solution is to use challenge menu to detect sequence change, and treat P5 and segments the same.

Another solution is to use bench also to detect sequence change. This way, P5 and most segments can be treated differently. But there are two shortcomings: (1) first segment cannot tell if it's the segment, or the P5; (2) it highly depends on GodSeeker+'s segment setup.

royitaqi commented 2 years ago

Solution one implemented in 7231059232315c73095c241112f2451a7f58a1d3.