search

roylee0704 / react-flexbox-grid

A set of React components implementing flexboxgrid with the power of CSS Modules.
http://roylee0704.github.io/react-flexbox-grid/
2.93k stars 206 forks source link

Upgrading react to v15.5.4. #107

Closed mastrauckas closed 7 years ago

mastrauckas commented 7 years ago

This removes warning Warning: Accessing PropTypes via the main React package is deprecated.. Facebook moved PropTypes from package React to prop-types starting in v15.5 as stated here.

roylee0704 commented 7 years ago

@mastrauckas Thanks! By the way, do we need to update the package.json file as well?

roylee0704 commented 7 years ago

@silvenon Do you think we should update to use React v15.5.x ?

mastrauckas commented 7 years ago

@roylee0704 The one thing I did not do was update the version number from 1.0.2 to 1.0.3 in package.json. Do you want me to update the version number or will you? You will need to update this when publishing to npm so someone can use1.0.2 if needed.

Also updating to react 15.5.x is not a big deal. If someone is using an older version of react they can use npm install react-flexbox-grid@1.0.2 which will give them the version that is using an older version of react.

roylee0704 commented 7 years ago

@mastrauckas Ah ha, I see! My original intent was wanting to ask if we need to include prop-types in the package.json as well? :)

mastrauckas commented 7 years ago

@roylee0704 Yes I should have added prop-types as part of package.json. I went ahead and added it.

roylee0704 commented 7 years ago

@mastrauckas You're super awesome! :)