search

roylee0704 / react-flexbox-grid

A set of React components implementing flexboxgrid with the power of CSS Modules.
http://roylee0704.github.io/react-flexbox-grid/
2.93k stars 206 forks source link

Style is not being imported after v1.1.4 #129

Closed lhas closed 7 years ago

lhas commented 7 years ago

After the last release v1.1.4, on my project, the grid stopped to work. It looks like the classnames are different and don't contain any stylesheet for it. You can help me on this, please? image

lhas commented 7 years ago

I fixed adding import 'react-flexbox-grid/lib/index.css'; to my main.js but not sure if this is the correct solution, specially because in v1.1.3 it works.

shan-du commented 7 years ago

We had the same problem, our solution is to just fix the version to 1.1.3 for now

roylee0704 commented 7 years ago

Sorry guys, kindly fix version to 1.1.3 until I figure out what's the issue.

roylee0704 commented 7 years ago

in 1.1.4, I merged this: https://github.com/roylee0704/react-flexbox-grid/pull/126

NicholasAsimov commented 7 years ago

Same problem here, 1.1.4 broke styles.

alevor657 commented 7 years ago

Same here, having troubles.

Taylor123 commented 7 years ago

Any update on this? I just ran into issues with v1.1.4

I'm not using any bundler at the moment. Could that be causing an issue on my end?

danny-andrews commented 7 years ago

This was my fault, folks. Sorry for the inconvenience. I have a fix up here.

danny-andrews commented 7 years ago

If someone here could try out this build https://github.com/roylee0704/react-flexbox-grid/pull/130 and make sure it fixes this, that would be greatly appreciated. It works for me, but would like to verify it fixes your guys' use-cases as well.

lhas commented 7 years ago

Thanks, @danny-andrews . Actually i'm using the v1.1.3 build. But monday i will try this new build. See ya!

rpedroni commented 7 years ago

Hey guys, any updates on this?

danielkrich commented 7 years ago

same !!! spent hours to figure out what's wrong with my project -.- the import 'react-flexbox-grid/lib/index.css' fixed it for me for now...

rajiff commented 7 years ago

Hi, is there any plan to fix this?

danny-andrews commented 7 years ago

I have a PR to fix it. Just waiting on one of the maintainers to look at it. @roylee0704 @silvenon.

danny-andrews commented 7 years ago

Can someone here give this a go and verify that it fixes your issues? The fix is on master. Note: you will have to run yarn compile in node_modules/react-flexbox-grid.

roylee0704 commented 7 years ago

@rajiff @danielkrich @rpedroni @lhas @shan-du @NicholasAsimov

Sorry for the wait. It should be fixed under release v1.1.5. =)