search

roylee0704 / react-flexbox-grid

A set of React components implementing flexboxgrid with the power of CSS Modules.
http://roylee0704.github.io/react-flexbox-grid/
2.93k stars 206 forks source link

Not compatible with with flexboxgrid2@>=7.0.0-alpha12 #145

Open houkanshan opened 6 years ago

houkanshan commented 6 years ago

Hi, recently I upgraded react-flexbox-grid, but found that all the padding of <Col> missing.

flexboxgrid2@7.0.0-alpha12 began to use [class^="col-"] selector instead of using class name explicitly. Which I believe will be dropped by css-loader's CSS Modules when we @import styles from 'flexboxgrid2/flexboxgrid2.css';

If we install react-flexbox-grid with yarn then everything will be fine because flexboxgrid2's version is locked to 7.00-alpha7 by yarn.lock. But if we install it with npm, then flexboxgrid2@7.1.0 will be selected according to ^7.0.0-alpha7 in package.json.

So currently can we just lock flexboxgrid2's version to 7.0.0-alpha7 in package.json?

Thank you!

hilarykitz commented 6 years ago

+1 for this issue. We lose all shared column styling and are only left with the column width class. Makes for a very sad looking grid.

jacargentina commented 6 years ago

My repo at https://github.com/jacargentina/flexboxgrid2 fixes this. @roylee0704 could u update to use my fork?

imevro commented 6 years ago

@jacargentina if we will switch forks just for minor bugs, we will never use stable software.

imevro commented 6 years ago

@houkanshan can you reproduce problem with css loader on codesandbox.io? Because it is absolutely valid css and if this bug is really with loader, we need file an issue to them.

imevro commented 6 years ago

Fixed in 7.2.0

jacargentina commented 6 years ago

@evgenyrodionov Who is in charge for new versions here? Getting that new dependency 7.2.0 would be nice!!

imevro commented 6 years ago

@jacargentina @roylee0704 I guess

jacargentina commented 6 years ago

@roylee0704 Please, publish a new version, having flexboxgrid2 updated to 7.2.0

jacargentina commented 6 years ago

@silvenon @heldr I've tried contacting @roylee0704 to its gmail, but not having response. Somebody is actively looking at the project? it is discontinued ?

silvenon commented 6 years ago

I merged the PR, but unfortunately I don't have permissions to publish the new version of react-flexbox-grid. 😢

heldr commented 6 years ago

Me neither 😢

jacargentina commented 6 years ago

@silvenon @heldr any way to contact @roylee0704 ? Is he alive?

silvenon commented 6 years ago

I'm sure he's alive 😄 he just doesn't seem to have a strong online presence or has other things to do. I reached out to him and will let you know if he replies. (Déjà vu. #99)

jacargentina commented 6 years ago

@houkanshan and everybody following. I've put this https://jacargentina.github.io/react-flexbox-grid/ It is full of updates! Cheers.