roylee0704 / react-flexbox-grid

A set of React components implementing flexboxgrid with the power of CSS Modules.
http://roylee0704.github.io/react-flexbox-grid/
2.93k stars 206 forks source link

printer.js:170 Warning: Unknown props #78

Open yanickrochon opened 7 years ago

yanickrochon commented 7 years ago

Using the package found at lifefilm:react-flexbox-grid, I get this error because the props are not cleaned up before assigning them to the element.

The form that should be used (which would be faster anyhow) is

const {
  xs, xsOffset,
  sm, smOffset,
  md, mdOffset,
  lg, lgOffset,
  reverse,
  className,
  tagName,
  children,
  ...others
} = this.props;

Then assign others as props to the element, this will result in props that are clean, and will get rid of the error.

yanickrochon commented 7 years ago

I could prepare a PR today if no one wants to fix this... the warnings are driving me crazy!

yanickrochon commented 7 years ago

Finally got some time to clone look closer into this issue, and it seems that I am loading from Atmosphere instead of npm. I'm the author of this package has not updated to the lastest.

aarosil commented 7 years ago

I noticed this is already fixed in the latest version of this package