search

roylee0704 / react-flexbox-grid

A set of React components implementing flexboxgrid with the power of CSS Modules.
http://roylee0704.github.io/react-flexbox-grid/
2.93k stars 206 forks source link

Horizontal overflow, Grid container (not fluid) used, body margin 0 #97

Closed amirmohsen closed 7 years ago

amirmohsen commented 7 years ago

This is an extension of this issue.

At certain screen sizes, I get a horizontal scrollbar due to the row overflowing. Similar to the above issue, this happens when body margin is set to 0. However, using the <Grid/> container doesn't help. If the Grid is set to be fluid, it works fine, but it doesn't work if fluid is false.

You can in fact reproduce this issue by just setting fluid to false on the demo page as you can see in my screenshot.

Please note that this only happens at certain screen sizes so as you resize the page, the horizontal scrollbar keeps appearing and disappearing. react-flexbox-grid

silvenon commented 7 years ago

Unfortunately this is a flexboxgrid issue, see kristoferjoseph/flexboxgrid#144. In the meantime use fluid and set the width of the wrapping element yourself.

amirmohsen commented 7 years ago

It's worth mentioning this in the readme file. As it stands, the static container is pretty much useless.

silvenon commented 7 years ago

Added.

amirmohsen commented 7 years ago

Thank you @silvenon. Closing the issue now as it is already being tracked on the flexboxgrid repo.