All tests passing - Githubissues

daviddias commented 7 years ago

Hi @roylines! Thank you for creating this module, it was the fastest way to get prometheus up and running for a simple service I've just created.

In order for it to work, I had to fix some things internally as APIs from restify, express and hapijs changed (I'm just using hapijs, but I figured I would fix all of them). With this PR:

[x] All tests are passing again
[x] Migration to StandardJS CodeStyle (it helps to keep styling coherent)
[x] Use of semver for deps.
[x] Remove of PeerDep and make prom-client an actual dep.

Let me know if you agree with all the changes. Thanks!

roylines commented 7 years ago

Thank-you David for this. I will take a look over the next couple of days.

roylines commented 7 years ago

published as epimetheus@1.0.50

daviddias commented 7 years ago

Woa, that was super fast. Thanks @roylines ! 🌟

roylines commented 7 years ago

David, Does this close any of the outstanding issues on this project? Roy.

daviddias commented 7 years ago

It fixes:

roylines / node-epimetheus

All tests passing #32