info for adding new examples and classes

[kashimAstro]

Hi roy,

I made a fork of your addons, I thought of giving help in adding new classes and new examples, before proceeding I wanted to ask if you have guidelines.

I have some examples integrated into openFrameworks:

face_landmark_detection_ex fhog_ex image_ex dnn_face_recognition_ex dnn_mmod_face_detection_ex dnn_inception_ex dnn_metric_learning_ex dnn_mmod_ex dnn_imagenet_ex dnn_introduction_ex dnn_introduction2_ex dnn_metric_learning_on_images_ex dnn_imagenet_train_ex dnn_mmod_dog_hipsterizer

I was thinking of ordering the class, making cleaner methods and adding parameters, with creating high-level objects, eg:

FaceRecognition. ImageNet. MetricLearnImage.* etc..

and add more functions for conversions, eg: matrix in ofPixels or conversely.

do you think it makes sense to create low-level objects? as:

DNNtools. SVMtools.

if I can help out, I ask you to give me a direction for development.

good day

[roymacdonald]

Hi Dario, wow thats a lot. Thanks. Along with @bakercp, @HalfdanJ and @genekogan we were discussing this https://github.com/bakercp/ofxDlib/issues/1 It would be great if you want to join us!

The idea is to make this addon just a very simple addon in charge of dealing with adding dlib into the OF project and providing functions to convert data back and forth from OF to dlib. Also provide some examples on how to use this data converters but not much more. Any other more specialized stuff would go in a different addon. This way it is easier to maintain instead of having a huge addon. All the best!

[kashimAstro]

https://github.com/kashimAstro/ofxDLib

I made a commit on my fork, I added this:

example-FaceRecognition-webcam/ example-FaceRecognition/ example-ImageNet/

libs/dlib/lib/linux64/libdlib.a

src/FaceRecognition.cpp src/FaceRecognition.h src/ImageNet.cpp src/ImageNet.h

and modify src/ofxDLib.h and addons_config.mk

it makes sense to do a pull request?

[roymacdonald]

Hi, thanks. This is great, but have you seen this addon https://github.com/bakercp/ofxDlib It's not the same as mine. We are planning to merge both into a single one. Maybe it is a better idea for you to fork that one as there are several examples you have already there. Maybe focus on the ones that are not there but you have.

I don't want to spend your energy on something that I plan to remove, as the examples.

Can you PR only the linux libdlib.a file and the changes to ofxDLib.h?

Actually I think that it might be a better idea if you make your own addon like ofxFaceRecognition, etc. and use my addon as a dependency. This way we keep my addon light, focused on the OF - dlib integration and your, eventually new, addon handles the specifics.

How does it sound to you?

[kashimAstro]

Hi @roymacdonald, sorry I only read all of this now. it's a good idea!

I'm not good with git, i have to understand how to do a PR of only two files.

I update you..

[roymacdonald]

@kashimAstro ha, no worries :) There are several way for just leaving two files in the PR. although I think that the best way would be to make a new PR, otherwise those other files will still appear in your PR's commits. If you dont mind I can do it my self. best

[kashimAstro]

Hi @roymacdonald, very sorry, but just now I got rid off work!

if I do a pull request for this branch: https://github.com/kashimAstro/ofxDLib/tree/ofxDLib_linux64

is it good for you? good day