search

royorel / StyleSDF

Other
536 stars 50 forks source link

A suggestion to rename variable #12

Open NIRVANALAN opened 2 years ago

NIRVANALAN commented 2 years ago

Hi, this is not a bug but I suggest you to rename this variable. The matrix constructed here is camera poses (c2w) but not extrinsics, which may cause confusions when reading the code... https://github.com/royorel/StyleSDF/blob/273ee0de1986ef78afe15a34e687f72450fafc29/utils.py#L135

royorel commented 2 years ago

Hi @NIRVANALAN,

You are indeed correct. I will update the variable name soon. Sorry for the confusion.