royriojas / esformatter-jsx

esformatter plugin: format jsx files (or js files with Facebook React JSX Syntax)
MIT License
142 stars 25 forks source link

Replace string like placeholder with variable #81

Closed webcarrot closed 8 years ago

webcarrot commented 8 years ago

See issue: https://github.com/millermedeiros/esformatter-quotes/issues/16

dacarley commented 8 years ago

This is a pretty nasty bug -- we've had to remove esformatter-jsx from our project entirely until this gets fixed.

royriojas commented 8 years ago

Sorry @webcarrot @dacarley,

This issue was really a nasty one, but just to confirm was the issue also happening if esformatter-jsx was the first plugin in the list of esformatter plugins?

dacarley commented 8 years ago

Yes -- esformatter-jsx was the first plugin listed in our config.

royriojas commented 8 years ago

esformatter-jsx@7.0.1 published

royriojas commented 8 years ago

I need to start adding tests that consider interaction with other plugins... It is really sad not being able to reproduce this issue in a unit test. It might comeback later :(