royriojas / eslint-friendly-formatter

A simple formatter/reporter for ESLint that's friendly with Sublime Text and iterm2 "click to open file" functionality
MIT License
198 stars 28 forks source link

The sort order is kinda strange #20

Closed cmalard closed 8 years ago

cmalard commented 8 years ago

Here is a list of files sorted by eslint-friendly-formatter (I changed 1 rule to trigger errors, so they are all about the same error) :

.../www/components/orders/orderService.js:93:1
.../www/components/messages/messagesService.js:85:1
.../www/components/orders/orderChangeStatus/orderChangeStatusController.js:48:1
.../www/components/orders/orderChangeStatus/orderChangeStatusController.js:49:1
.../www/components/orders/orderChangeStatus/orderChangeStatusController.js:51:1
.../www/components/orders/orderChangeStatus/orderChangeStatusController.js:125:1
.../www/components/orders/orderDelay/orderDelayController.js:48:1
.../www/components/orders/orderDelay/orderDelayController.js:52:1
.../www/components/orders/orderQuestionsRedirectService.js:41:1
.../www/components/orders/orderQuestionsRedirectService.js:43:1
.../www/components/orders/orderService.js:80:1
.../www/components/orders/directives/orderInfoDirective.js:29:1
.../www/components/orders/orderService.js:130:1
.../www/components/orders/orderService.js:132:1
.../www/components/orders/orderService.js:143:1
.../www/components/orders/orderService.js:145:1
.../www/components/orders/orderService.js:467:1
.../www/components/orders/orderService.js:473:1
.../www/components/orders/questionsList/questionController.js:55:1
.../www/components/orders/questionsList/questionController.js:94:1
.../www/components/orders/questionsList/questionsListService.js:29:1
.../www/services/geolocationService.js:88:1
.../www/services/photoService.js:46:1
royriojas commented 8 years ago

hi @cmalard,

thanks for reporting it, can you also provide the command that use to run eslint with the formatter?

please let me know

cmalard commented 8 years ago

;-)

(I simply used : $(npm bin)/eslint -f '/node_modules/eslint-friendly-formatter' ./)

royriojas commented 8 years ago

I see. OK, thanks for your PR. will merge