search

royriojas / eslint-friendly-formatter

A simple formatter/reporter for ESLint that's friendly with Sublime Text and iterm2 "click to open file" functionality
MIT License
198 stars 28 forks source link

Fix trailing color in new lines #23

Closed eladchen closed 6 years ago

eladchen commented 8 years ago

When the output is constructed, new lines are included in the colored string.

eladchen commented 8 years ago

Whoa ! The unit tests are nearly impossible to make out.

There's two reasons why the build is failing:

  1. The code was committed without using the npm task 'beautify'.
  2. The tests are failing due to the output structure being changed.

I can fix the first issue, but the second is nearly impossible to make out. Those tests 'results.txt' are not human friendly.

royriojas commented 8 years ago

@eladchen. I can help with the other tests. fix the beautify and push, I can help with the tests. They are more like snapshot testing than actually unit testing (I mean I was not expecting a human generating those outputs :) )

In any case as I said I can fix those once beautification is fixed.

royriojas commented 7 years ago

Sorry man for the long delay on this branch, can you run npm run lint on this branch to make sure files are beautified? that is the only thing missing in this branch and it will be merged.

eladchen commented 7 years ago

I'll do it asap.

royriojas commented 6 years ago

I manually merged this PR. thanks @eladchen Sorry for the big delay in working on this.