search

royriojas / eslint-friendly-formatter

A simple formatter/reporter for ESLint that's friendly with Sublime Text and iterm2 "click to open file" functionality
MIT License
198 stars 28 forks source link

Upgrade chalk to v2.0.1 && DO NOT use removed method `chalk.stripColor` #28

Closed hsxfjames closed 7 years ago

hsxfjames commented 7 years ago

I've noticed that if I try to upgrade chalk package to v2.0.1 in my devDependencies, eslint-friendly-formatter will not work since it depends on chalk@^1.0.0, using a removed method chalk.stripColor in chalk@2.0.1. So I hope you can upgrade dependencies too. thx

royriojas commented 7 years ago

hi @hsxfjames

Thanks for the PR, would you mind update the tests snapshots? I will merge and publish a new version after it is updated.

Thank you very much.

hsxfjames commented 7 years ago

hi @royriojas I've updated the test snapshots, please check if there is any problem. thx.

royriojas commented 7 years ago

hi @hsxfjames thank u very much, I've merged it. Will test and publish a new version soon