search

royriojas / eslint-friendly-formatter

A simple formatter/reporter for ESLint that's friendly with Sublime Text and iterm2 "click to open file" functionality
MIT License
198 stars 28 forks source link

Error Changing Fonts #30

Closed gartnera closed 6 years ago

gartnera commented 6 years ago

On the following line, you try to use the \033]50 \007 combination to set the font of your output.

https://github.com/royriojas/eslint-friendly-formatter/blob/32a1e55d29fbbd3bb15a723c16f06b729de8d27d/index.js#L248

However, setting the font to CurrentDir=... doesn't make any sense. What are you trying to do here? Can we remove this or set it to something sensible?

On most terminals this is silently ignored, but mintty raises an error every time (https://github.com/mintty/wsltty/issues/87).

royriojas commented 6 years ago

Hi @gartnera That is just a trick for iterm to understand relative paths. But we can hide behind a flag so it doesn't impact mintty users.

Pull requests are welcome if you are interested.

krubokrubo commented 5 years ago

I had the same problem using eslint from an ssh session from cygwin. I had used vue init webpack which gave me eslint-friendly-formatter@^3.0.0, which still has the bug. Thanks to your fix, I was able to solve it by upgrading to eslint-friendly-formatter@4.

However, it would be really nice if you could publish this fix as version 3.0.1, since tools like vue-cli are still installing eslint-friendly-formatter@^3.0.0. These tools would automatically update to version 3.0.1, but they don't automatically update to 4. Would you consider publishing this fix as 3.0.1?

royriojas commented 5 years ago

hi @krubokrubo

Of course. Will check how difficult would it be to have the fix on this repo. Thanks for reporting it.