search

royriojas / eslint-friendly-formatter

A simple formatter/reporter for ESLint that's friendly with Sublime Text and iterm2 "click to open file" functionality
MIT License
198 stars 28 forks source link

Google search link seems outdated #45

Closed Xerillio closed 3 years ago

Xerillio commented 3 years ago

Before going into details, is this project still active? It seems there hasn't been much activity for a few years.

The bug report

The formatter produces links for non-standard/3rd party ESLint rules by pointing to Google Search with the following prefix in the URL: https://google.com/#q=. It seems this is an outdated format for Google Search links and it should instead be: https://google.com/search?q=.

If it's of any interest, I'll happily create a pull request for this fix as well as for a few other additions/improvements you can find in my fork here: Xerillio/eslint-friendly-formatter

royriojas commented 3 years ago

sure that would be awesome!

Xerillio commented 3 years ago

@royriojas I've added a PR now. I'll create another issue with some suggested additions you can consider if you want to include in this project.

royriojas commented 3 years ago

Thanks @Xerillio will review it