search

roysmith / spi-tools

8 stars 3 forks source link

add `parse_socklist` method to accommodate new template #206

Closed TamzinHadasa closed 2 years ago

TamzinHadasa commented 2 years ago

@roysmith I wasn't able to run unit tests on my own end, because there's aspects of the file structure that were opaque to me and throwing unrelated errors on my machine, but I think this should be pretty straightforward. Obviously let me know if anything needs changing.

roysmith commented 2 years ago

I'll be happy to work with you on the unit tests, but could you generate a diff against the dev branch, please?

I've never actually tried to run the tests outside of Toolforge, but I don't think there's anything that won't run anywhere as long as you set up the right venv. But let's start by getting this over to dev. My workflow is to put all new code on dev and once I'm sure https://spi-tools-dev.toolforge.org/spi/ is stable, merge it over to master.

TamzinHadasa commented 2 years ago

closed due to GitHub issues. stand by.