search

roystgnr / MetaPhysicL

Metaprogramming and operator-overloaded classes for numerical simulations
Other
22 stars 12 forks source link

Create metaphysicl_dbg_var to eliminate compiler warnings #48

Closed lindsayad closed 5 years ago

lindsayad commented 5 years ago

Currently when compiling in optimized modes we will get warnings in some functions that only use their parameters in debug mode. I created metaphysicl_dbg_var as an analog to libmesh_dbg_var to address this issue.

roystgnr commented 5 years ago

Thanks!

I should probably transfer the libMesh --enable-werror and --enable-paranoid-warnings configure options over and start using them...

lindsayad commented 5 years ago

Do @dschwen's recent additions warrant a patch increment and tag? Otherwise I'm going to do a PR bootstrap. We're moving to dynamic derivative storage in MOOSE and can't do it until this PR's changes are incorporated.

roystgnr commented 5 years ago

Yeah; go for a full increment. That was a significant oversight fixed.

lindsayad commented 5 years ago

A minor version increment? 0.5.0?

roystgnr commented 5 years ago

Eh, let's call it 0.5.0. We'll probably be good to go for 1.0.0 before too long at this rate so no need to be stingy with the increment sizes.