search

roystgnr / MetaPhysicL

Metaprogramming and operator-overloaded classes for numerical simulations
Other
22 stars 12 forks source link

Allow operations between std::complex<T> and T #52

Closed lindsayad closed 5 years ago

lindsayad commented 5 years ago

Previously we had CompareTypes defined for ops between std::complex and T where T != U, but not for T == U. This remedies that

roystgnr commented 5 years ago

Thanks!

lindsayad commented 5 years ago

@roystgnr, @cticenhour needs this for some electromagnetics. I think this is worthy of a patch release (even though it would only contain the contents of this PR) but I can also just do a bootstrapped PR if you disagree

roystgnr commented 5 years ago

A patch release sounds good to me; this is a significant bugfix, no?

lindsayad commented 5 years ago

I would say so

On Sat, Jul 27, 2019 at 4:41 PM roystgnr notifications@github.com wrote:

A patch release sounds good to me; this is a significant bugfix, no?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/roystgnr/MetaPhysicL/pull/52?email_source=notifications&email_token=ACOGA4FUY6BZRPIEJKAPFHDQBTMLXA5CNFSM4IB33FVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26UOLY#issuecomment-515721007, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOGA4HKNIRB3OHF27HMZOTQBTMLXANCNFSM4IB33FVA .