search

rozPierog / Cofi

Free and open-source coffee brew timer. Customizable time settings and an easy-to-use interface. Perfect cup every time.
https://rozpierog.github.io/Cofi/
GNU General Public License v3.0
352 stars 30 forks source link

Dark statusbar on dark background #17

Closed rozPierog closed 3 years ago

rozPierog commented 3 years ago

Screenshot_20211013-204717_Cofi.jpg

AdiAr11 commented 3 years ago

hi, what needs to be changed here? Can i help?

rozPierog commented 3 years ago

Hi @AdiAr11 sure you can! Problem is that we don't know what color is behind status bar (because of Material You/Monet) so we can't set statusbar color accordingly. There is luminance() prop in Color that could tell us how bright that color is in 0.0f-1.0f eg. 

MaterialTheme.colors.surface.luminance() > 0.5f

and based on that we can set status bar icons color using 

WindowInsetsControllerCompat.isAppearanceLightStatusBars = !isColorBright

If you decide to work on it, create a Draft PR so I can answer your questions there

AdiAr11 commented 3 years ago

thank you. i'll try it and get back to you.

iamyajat commented 3 years ago

Hey @rozPierog, can I work on this?

rozPierog commented 3 years ago

@iamyajat I see no reason not to. Unless @AdiAr11 is working on it in secret then it would be shame to double the work

AdiAr11 commented 3 years ago

@rozPierog I'm really very sorry to keep you waiting,I got a little busy. I'll create a draft pr. @iamyajat please feel free to continue with this issue, It might take longer for me to complete. Again really sorry !!