search

rozPierog / Cofi

Free and open-source coffee brew timer. Customizable time settings and an easy-to-use interface. Perfect cup every time.
https://rozpierog.github.io/Cofi/
GNU General Public License v3.0
352 stars 30 forks source link

Edit recipe - saving steps #41

Closed oJankowiak closed 2 years ago

oJankowiak commented 2 years ago

Cofi Version - 1.3.4 Device - pixel 4 OS - Android 12

When creating a new recipe or editing a current one, if you leave all the fields blank without filling them and save, the app adds a step without any data (empty step).

I don't know if this should be the case, or if it should inform the user to fill in some data.

Screenshot_20220123-171335.png

MundhadHarsh commented 2 years ago

I would like to work on this issue, can you please assign it to me.

rozPierog commented 2 years ago

Here you go @Sherlock-Holmes-2-2-1

MundhadHarsh commented 2 years ago

Thank you

MundhadHarsh commented 2 years ago

Hey, I have fixed the issue, but I am not able to push it remote: Permission to rozPierog/Cofi.git denied to Sherlock-Holmes-2-2-1.
can you give me access or tell me what to do next. It will be my first push.

rozPierog commented 2 years ago

I'm happy to hear that you could find a fix for this issue @Sherlock-Holmes-2-2-1 I'm not gonna give you access to my repository, for creating a Pull Request to this repo you will need to set up a fork. Here is a link to the Github Docs about that https://docs.github.com/en/get-started/quickstart/fork-a-repo If you have any issues with that I'll be happy to help

MundhadHarsh commented 2 years ago

Thank you, created a pull request, kindly review it, and if possible merge it.