search

rozbb / saber-rs

A pure-Rust implementation of the Saber key encapsulation mechanism (KEM)
Other
4 stars 1 forks source link

Fix some `no_std` nits #1

Closed pinkforest closed 3 months ago

pinkforest commented 3 months ago

Noticed this - separate PR

You'll need std for it's Error - however it's being brought to core but that requires high MSRV 1.80

rozbb commented 3 months ago

Ok I've actually removed all uses of std/alloc in the crate, so the extern crate thing isn't necessary anymore. Regarding feature flags, are you sure it's necessary? Currently the only that needs std is tests/kat.rs. Can we just omit features entirely and say that KAT needs std?

pinkforest commented 3 months ago

Cool ok - it's just standard feature flags but no worries makes sense - However if you have any Errors and you would like to support MSRV < 1.80 (not yet released) then I suggest using std feature to allow error gating to std's Error if you have fallible implementations - I left another issue for unwrap() as I wasn't sure what was the intent with panic over errors

rozbb commented 3 months ago

Thank you!

rozbb commented 3 months ago

Ugh it's complaining about something

https://github.com/rozbb/saber-rs/actions/runs/9634880583/workflow

pinkforest commented 3 months ago

Extra linefeed there, the yaml is pits