rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.13k stars 38 forks source link

Build tag generation is scuffed when there's no git metadata #237

Closed rozniak closed 1 year ago

rozniak commented 1 year ago

The build process currently does not handle the situation where there is no git metadata. This can occur if a user downloads this project as a ZIP, rather than via git clone.

The usual format of builds is currently: <commit hash>.<branch name>(<user>).<timestamp>

As a result, with no metadata the tag becomes: .(<user>).<timestamp>

Aside from being rubbish, this causes issues because the leading . means the build will be output into a hidden directory, potentially confusing the user when they have xptc/ with no contents.