rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.11k stars 37 forks source link

dpa - support creating desktop windows properly #288

Closed rozniak closed 7 months ago

rozniak commented 7 months ago

Currently there's only a single function for becoming a desktop window. Ideally it should be possible to create desktop windows bound to separate monitors, because one single massive window has flaws - only works on X11 with the whole workspace, and also makes it difficult to separate the actual views (which will be important when the shell has integration into the desktop).

Probably need to create a separate GtkApplicationWindow derived class that takes a screen as an argument or something? Depends how this works between X11/Wayland.

rozniak commented 7 months ago

This is almost done, just needs testing to ensure the Wayland implementation works. X11 seems okay on my machine!

Implementation is to have WinTCDpaDesktopWindow class which handles all the display protocol stuff for becoming the desktop window, rather than having a specific function for doing so. Right now wintc-desktop just iterates over the monitors on the default display, and creates a desktop window for each one.

rozniak commented 7 months ago

This is a little more difficult to test... Wayfire has changed massively since I last used it for testing, and no longer works in VirtualBox for me. :weary:

rozniak commented 7 months ago

With massive pain and suffering, I have confirmed that the desktop changes do work under Wayland.