search

rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.11k stars 37 forks source link

Taskband segfaults #306

Closed rozniak closed 5 months ago

rozniak commented 5 months ago

On Arch Linux (potentially other distros, unsure atm), the taskband seems liable to crashing, but it's not the same crash that I traced to GTK3 in #292 (Arch Linux is on 3.24.42 as of the time of writing).

rozniak commented 5 months ago

Reproducible by displaying a window that has no assigned icon, and no application ID set. (eg. open 'Printers and Faxes' from the Start menu, then close that window)

The crash appears to come from WNCK... image

However there is a fault in shelldpa when it attempts to read the icon name from the WM_CLASS attribute when the window is using a fallback icon. Not checking if WM_CLASS attrib is NULL before calling gtk_icon_theme_load_icon image

Will fix the latter issue, not sure if it will have any influence on the former but it still should be fixed.

rozniak commented 5 months ago

NTS: I have a sneaking suspicion this issue may be that the error dialog is blocking, so the calls to WNCK to retrieve the window data will run after the dialog is destroyed - will need to check this once I have time

rozniak commented 5 months ago

Doesn't appear to be a modal dialog issue, it's just when the GtkMessageDialog is closed regardless, WNCK crashes. It definitely seems like a WNCK bug but not sure why

rozniak commented 5 months ago

Identified the double whammy problem:

Will apply some fixes now, I guess this has just been working by pure chance on Debian. :weary:

TheoCGaming commented 4 months ago

still happening for me archlinux kernel 6.10 aur package r322.150f0cb-1 not sure how to get it to produce logs

TheoCGaming commented 4 months ago

making a new issue (cause is completely different)