search

rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.11k stars 37 forks source link

Updated README.MD #329

Closed acdavit closed 3 months ago

acdavit commented 5 months ago

Added pip to the required tools

rozniak commented 5 months ago

The thing is... the venv itself should be the source of pip - not the distro. Essentially that is the purpose of the venv: to have a contained installation so that your system environment doesn't get polluted - if you take a look at the CMakeLists.txt, it actually does directly call the pip that's contained in the venv: https://github.com/rozniak/xfce-winxp-tc/blob/master/packaging/cmake-inc/themes/CMakeLists.txt#L45

There must be more at play here, need to figure out why this command failed. Supposedly venv-setup completed according to that log, I guess because the directory was created but it actually failed the command itself somehow. Perhaps this needs testing on a plain Debian VM without installing pip, just python and then test out creation of the venv and usage of .venv/bin/pip install -r requirements.txt --upgrade to see whether it fails and why. 🤔

Edit: For reference this PR relates to #328