search

rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.11k stars 37 forks source link

Improvements for comctl default styles and CPLs #339

Closed rozniak closed 2 months ago

rozniak commented 4 months ago

Fix up some more broken / unfinished styling:

rozniak commented 2 months ago

Working on this...

I have resolved the broken appearance of the run dialog under Adwaita, this is basically because the run dialog is still very rough in how it handles the UI. It does not use resource XML or CSS for its UI, it's all hard-coded in the C from before I knew much about GTK programming. I am not fully rewriting all that in this issue, I have just fixed some stuff up enough for it to be good looking in both Adwaita and the themes in this repo.

Worth noting though that button placements vary in Windows XP... I suppose due to the manual design of the dialogs and stuff. Some have buttons spaced really wide (like the Run dialog), some have them spaced normally like the CPLs, and some have them spaced really close (like taskmgr).

I'm thinking I will just opt for normal spacing unless it's noticeably different in Windows XP, so taskmgr will have the same button spacing as the CPLs. It will just be easier and arguably nicer that way...

NTS: Check winver after these changes... missing margin

rozniak commented 2 months ago

image

Should be much of an improvement over the existing lack of margin...

rozniak commented 2 months ago

For reference - this is what it all looks like with Adwaita. So should be compatible with other themes...

image

MrMegarich commented 2 months ago

That's so accurate! But one nitpick I have is the lack of the indented border around the background selection. Otherwise looks great! 😊

MrMegarich commented 2 months ago

diagram

What I mean

rozniak commented 2 months ago

Yeah I know - it's something I need to look at later with the frames to see if it's something to apply on list boxes directly, or whether it needs an outer frame (don't want to break other programs appearances that use list boxes)

rozniak commented 2 months ago

@MrMegarich #353 :grin: