search

rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.11k stars 37 forks source link

Distro-agnostic way of installing the themes #344

Open spavaonica opened 4 months ago

spavaonica commented 4 months ago

I don't really understand the idea behind only packaging the themes for specific distros. That might be great if you want to maintain some repos so people can easily install the themes. But what if I just want to install some cursors, icons, and fonts on a distro that's not supported? I'm on Gentoo and all the scripts in packaging just abort with a "Unsupported distribution" message.

Initially I thought it's some fonts, cursors, and themes. I can probably copy them into the right locations manually. But if that were the case, there would be some mention of it on the main readme or at least the wiki.So if you have to actually compile everything, why does it build a distro-specific package? That seems to be the most complicated and least portable way of making it.

I think some kind of local compilation would be good. Skip the dependency checks, write a warning about them, and just build them into the actual directory that the git repo was cloned into. The user can then copy the files they need into the respective directories themselves, in case something isn't distro-agnostic anyways.

That would make for a portable version that could work on virtually any *nix system and it would probably be fairly easy to maintain as well. It just needs a warning that certain things might not work automatically, but it's a better alternative than just aborting with "unsupported distribution".

rozniak commented 4 months ago

The packaging is done because I prefer native packages for install/uninstall over just a make install and manual make clean steps. That, and it makes it easier to write the interactive setup and potentially host a repo in future. :grin:

I do have #200 for sorting out Gentoo. There is actually a raw package type supported in the CMake stuff but currently the scripts don't use it and rely on distid.sh. It should be possible to just add a switch to the scripts to use raw as the input to WINTC_PKGMGR and it just output the build with no packaging metadata. Something to look into perhaps in the meantime. :thinking:

The Wiki is pretty incomplete as I've been quite busy irl recently (and will be for at least another 2 weeks). Sorry it's a bit of a pain still.