rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
979 stars 34 forks source link

Does not work on any other Debian/Ubuntu-based distros other than Debian #79

Closed VNGamerGit closed 2 years ago

VNGamerGit commented 2 years ago

I tried installing this theme on XFCE Desktop Environment + Zorin OS 16 Core (Debian/Ubuntu-based), and other than the windows borders (if you do not know what I mean, look at the first screenshot), nothing seem to change at all (look at the second one down below) Screenshot_2021-09-28_14-17-38

Screenshot_2021-09-28_14-18-18

rozniak commented 2 years ago

I'll install Zorin and have a look when I get a chance.

I don't know if this applies to Zorin but usually in XFCE the window manager (XFWM4) and system theme (GTK) are in separate settings so you have to select Luna in both. I don't know if it's as simple as that but I thought I'd mention it just in case. 😃

VNGamerGit commented 2 years ago

I'll install Zorin and have a look when I get a chance.

I don't know if this applies to Zorin but usually in XFCE the window manager (XFWM4) and system theme (GTK) are in separate settings so you have to select Luna in both. I don't know if it's as simple as that but I thought I'd mention it just in case. 😃

Hey, can you try other Debian/Ubuntu-based distros? The installation guide and file seems to be targeted towards Debian only, not Debian/Ubuntu-based distros Edit: I want to clarify that the guide seems to be fully compatible with Debian only for some unknown reason. You can install this on other distros that are based on it (like Ubuntu), though the results might end up like mine

rozniak commented 2 years ago

Yeah the README needs updating + work done on packaging for other distros etc.

Does the Luna theme not appear under the Appearance settings in XFCE?

VNGamerGit commented 2 years ago

Yeah the README needs updating + work done on packaging for other distros etc.

Does the Luna theme not appear under the Appearance settings in XFCE?

it does appear under the Windows Manager settings, but not the GTK/Icons/Cursors menu for some reason Edit: Sorry, should be Windows Manager, was busy so I did not remember that the theme only appear in the WM menu, not the GTK Appearance

rozniak commented 2 years ago

Huh, the theme setting under Appearance should set the GTK theme, does it not do anything?

As for icons/cursors, they have their own packaging scripts at the moment.

For cursors, use the packcurs.sh script under /packaging/deb/cursors to generate a .deb file for each cursor theme. There's only "standard" with and without pointer shadows currently. So use ./packcurs.sh no-shadow/standard shadow/standard to generate the packages then you can install them.

For icons, they're not totally done yet but you can checkout the feat-72 branch and there should be packicon.sh under /packaging/deb/icons. Again can generate the icon theme package by issuing ./packicon.sh luna and then you can install the deb it outputs.

VNGamerGit commented 2 years ago

Huh, the theme setting under Appearance should set the GTK theme, does it not do anything?

As for icons/cursors, they have their own packaging scripts at the moment.

For cursors, use the packcurs.sh script under /packaging/deb/cursors to generate a .deb file for each cursor theme. There's only "standard" with and without pointer shadows currently. So use ./packcurs.sh no-shadow/standard shadow/standard to generate the packages then you can install them.

For icons, they're not totally done yet but you can checkout the feat-72 branch and there should be packicon.sh under /packaging/deb/icons. Again can generate the icon theme package by issuing ./packicon.sh luna and then you can install the deb it outputs.

The theme does not appear in Appearance, and it only appears in the windows manager menu

VNGamerGit commented 2 years ago

For cursors, use the packcurs.sh script under /packaging/deb/cursors to generate a .deb file for each cursor theme. There's only "standard" with and without pointer shadows currently. So use ./packcurs.sh no-shadow/standard shadow/standard to generate the packages then you can install them.

Got the You are missing package: rename error while running the command you sent, help for this?

For icons, they're not totally done yet but you can checkout the feat-72 branch and there should be packicon.sh under /packaging/deb/icons. Again can generate the icon theme package by issuing ./packicon.sh luna and then you can install the deb it outputs.

Huh, they're actually not done. Anyway, the icon pack somehow changes the folder icons into the same icon as the files, which is confusing, even though there's actually icons for folders in the icons folder

rozniak commented 2 years ago

Got the You are missing package: rename error while running the command you sent, help for this?

That'll be due to this - the script uses dpkg to check if required packages are installed: https://github.com/rozniak/xfce-winxp-tc/blob/master/packaging/deb/cursors/packcurs.sh#L35

Huh, they're actually not done. Anyway, the icon pack somehow changes the folder icons into the same icon as the files, which is confusing, even though there's actually icons for folders in the icons folder

Can you post pics on #72 ?

VNGamerGit commented 2 years ago

Huh, they're actually not done. Anyway, the icon pack somehow changes the folder icons into the same icon as the files, which is confusing, even though there's actually icons for folders in the icons folder

Can you post pics on #72 ?

Posted. Now, what about this bug/issue?

rozniak commented 2 years ago

Do you use dpkg ?

EDIT: Missed your comments regarding the missing theme under Appearance... the script puts it under gtk-3.0, I have seen other themes specifically use a directory called gtk-3.24. Might need a symlink or something... perhaps you could compare the Luna theme under /usr/share/themes with another one in there that works?

VNGamerGit commented 2 years ago

Do you use dpkg ?

EDIT: Missed your comments regarding the missing theme under Appearance... the script puts it under gtk-3.0, I have seen other themes specifically use a directory called gtk-3.24. Might need a symlink or something... perhaps you could compare the Luna theme under /usr/share/themes with another one in there that works?

So you want me to compare the Luna theme in this system (that doesn't work) with the one that works?

rozniak commented 2 years ago

Yeah like in the file system, Luna should have gtk-3.0 in there with gtk.css, ould be curious to know if it needs to be more specific or something.

rozniak commented 2 years ago

Sorry for the wait, just setting up Zorin in a VM to have a play from here.

rozniak commented 2 years ago

@VNGamerGit I just tried it and Luna is under Appearance as expected - you not seeing this on your install?

image

VNGamerGit commented 2 years ago

@VNGamerGit I just tried it and Luna is under Appearance as expected - you not seeing this on your install?

image

Yeah, seems like so. Sorry for not replying to your last reply about the .css file, was busy. But anyway, if it does not appear, can I just copy the files into the themes folder in /usr/share?

toastom commented 2 years ago

I'm following this issue too. Getting the same problems as @VNGamerGit , but I'm using a Debian Bullseye VM.

toastom commented 2 years ago

This may or may not help you on Zorin, but I got the Luna theme to show in Settings > Appearance on Debian 11. I first had to install ruby-sass, which is why the installer failed to copy over the theme for me. sudo apt-get install ruby-sass Then I could run the installer in the "packaging" directory. ./build-deb.sh sudo dpkg -i debian.deb

Again, I had the same issues as you @VNGamerGit and this worked for me on Debian 11. Not sure if this will help on Zorin. I was just missing a dependency. Perhaps a README update could make sure this is addressed.

rozniak commented 2 years ago

Thanks Tom mate, yeah that info is missing my apologies - the themes are written in SASS rather than straight up CSS so need transpiling, which is what the script does. Install the sass package and retry the install as Tom says, hopefully it will work. Sorry I totally forgot to explain that.

private-boolean commented 2 years ago

@VNGamerGit I just tried it and Luna is under Appearance as expected - you not seeing this on your install?

image

I'm having some trouble getting the start menu to work... perhaps I am ignorant to debian/XFCE :) on Xubuntu 20.04 I have successfully followed your directions in this thread (including installing sass) and I have a desktop like in this screenshot :)

I notice that there is just a default application launcher here too. I tried choosing the custom menu file 'startbutton.desktop' but I get an error when i try to load it:

'Error on line 1 char 1: Document must begin with an element (e.g. )'

rozniak commented 2 years ago

@private-boolean Have you built the plugins? Under /shell there is the Start menu and system tray plugins - they build with cmake (cmake should tell you what you need to build - things like libxfcepanel, libxfceutil, libgarcon, not exact names but you should be able to search, you can see them in the CMakeLists.txt).

To build it's the same as any cmake project, cd into /shell/start (for example), mkdir build, cd build, then cmake .. to generate a makefile - it will give you any dependency errors here so check them, once it's happy, do make to build the panel plugin. Do the same for /shell/systray as well.

Info on where to put the stuff is on my first comment on #21 - but feel free to ask if you need more help. Once everything is in the right place, you should be able to add the plugins to the panel.

I will get around to writing things up and improving packaging at some point I've just been unusually busy these past few weeks. :sweat:

EDIT: Also been a bit busy drawing icons for #72

private-boolean commented 2 years ago

Thanks for the reply! I tried following those directions and everything built correctly but the plugins were not showing up in panel settings.

I opted to try reinstalling since it was an otherwise fresh OS installation, but now the window borders aren't working (even though I used the test-borders branch of xfce-winxp-tc-panel 😅). Which OS do you use? I selected Xubuntu 20.04 since I reasoned that it already had xfce built in, but that wound up not helping because it only supports 4.14 out of the box.

PS this is great work and I'm looking forward to showing off my MacBook-running-Linux-that-looks-like-Windows-XP 😁😁😁

<edit: saw your note about window manager, that got the borders working>

<further edit: I noticed that xfce-panel was not picking up any plugins in /usr/shared/..., it appears that if I cop the plugin to /usr/local/share/xfce4-panel/..., the Add... dialog box picks it up, but when i try to add the startbutton, it just crashes. Is there an easy way to debug? I am not familiar with XFCE4 in the least :)

private-boolean commented 2 years ago

EDIT: Also been a bit busy drawing icons for #72

I've got a Windows XP laptop sitting around, let me know if you need any specific icons, I can grab them very easily and save you some googling.

rozniak commented 2 years ago

I opted to try reinstalling since it was an otherwise fresh OS installation, but now the window borders aren't working (even though I used the test-borders branch of xfce-winxp-tc-panel :sweat_smile: )

FYI that repo is not for window borders (xfwm4) - it's for the panel (xfce4-panel). The test-borders name has to do with the fact that the panel always has a border, and I wanted to remove it via the source code. In any case the correct branch to use from there is experiment-build which has a packaging repo for building .debs. It exists to fix the borders and a theming bug with xfce4-panel.

A bit confusing... yet another thing to clear up I suppose. :sweat_smile:

Which OS do you use? I selected Xubuntu 20.04 since I reasoned that it already had xfce built in, but that wound up not helping because it only supports 4.14 out of the box.

I use Debian 11 which has XFCE 4.16. The only thing that broke between 4.14 and 4.16 for this repo was some header files were named differently. For 4.14, reversing the changes made in this commit would get it building again for that older version: https://github.com/rozniak/xfce-winxp-tc/commit/0484853f5a36728666ffac83c5b5a11afaaa2753

I noticed that xfce-panel was not picking up any plugins in /usr/shared/..., it appears that if I cop the plugin to /usr/local/share/xfce4-panel/..., the Add... dialog box picks it up, but when i try to add the startbutton, it just crashes. Is there an easy way to debug? I am not familiar with XFCE4 in the least

Maybe your distro is storing them in a slightly different place? The plugin should live with all the other XFCE plugins, and the desktop entry thing should live with the rest too. You might be able to do like a find /usr -type f -iname "systray.desktop" for instance to find where they are if they're in a different spot?

I've got a Windows XP laptop sitting around, let me know if you need any specific icons, I can grab them very easily and save you some googling.

I have an XP VM with various MS software installed for the era (like Office 2003, Visual Studio 2005) for acquiring icons and resources. Also have ripped Office 2007 UI icons (imageMso). The drawing is because some icons only exist in one size so have to draw the other size manually.

private-boolean commented 2 years ago

OK. i got the start menu to work: it turns out I needed to select 'XFCE Session' at the login screen to change my DE from the default Xubuntu desktop environment. I suppose it was using the xfce4-panel from the Xubuntu repos instead of the one I built from your fork.

I can help with the documentation if you like, I can write this up as a pull-request for the readme if you like. That should help with the getting started experience and you can close this issue.

rozniak commented 2 years ago

OK. i got the start menu to work: it turns out I needed to select 'XFCE Session' at the login screen to change my DE from the default Xubuntu desktop environment. I suppose it was using the xfce4-panel from the Xubuntu repos instead of the one I built from your fork.

The Start menu will work in the upstream xfce4-panel - the only differences is that there is a top border and the background is not transparent (due to a bug in the panel). It still loads though, so not sure unless it was using a different DE entirely?

I can help with the documentation if you like, I can write this up as a pull-request for the readme if you like. That should help with the getting started experience and you can close this issue.

Probably best to write the guide in a new doc, like INSTRUCTIONS.MD or something and link to it from README.MD. Only reason I say that is it's so manual at the moment that the steps would probably bloat the README too much if it's all in there.

rozniak commented 2 years ago

FYI guys once #85 is done this shouldn't be as much of a problem. I'm writing up documentation for everything now, and I have replaced the crappy old packaging script for the theme with a new one that checks these package dependencies so you hopefully won't be left in the dark.

Working in feat-85 at the moment, there will be packaging scripts for everything (including the forked XFCE stuff). deb targeted at first, I will do some thorough testing on some of the downstream Debian-based distros. :grin:

rozniak commented 2 years ago

Closing this as I don't think it requires any further support and the recent documentation/packaging updates in #85 should prevent similar confusion in future.