Closed MarkusAmshove closed 5 years ago
Having the current commands in mind, I think it might make more sense to split the command up.
New commands:
That way the select issue under cursor
could be used instead of entering an issue id for List actions for issue
and the bulk update could just be another action in actions for issue
Thank you for the review, I'll split the functionality as suggested and keep your comments in mind.
I'm not that experienced with JS/TS stuff, that's why I didn't know how to handle the error cases from a Promise correctly. That's why I implemented the the validation (reread issue and confirm updates) in the first place :-)
Should I split those two into separate PRs or are two features in one PR okay for you?
That's why I implemented the the validation (reread issue and confirm updates) in the first place :-)
Oh, so it's due to error handling, not potential partial update by redmine? Well then, also this reread should be removed. I deduced by your code that redmine can do partial update, but now I know it doesn't. ;)
You can keep these features in this PR, as it is.
Thanks and I'm looking forward to merge your PR :)
It does partial update, e.g updating the assignee but not status. So I thought rereading and notifying the user about a partial update would be good UX.
I would like to keep the reread and change the user facing warning message to "Issue partially updated" with the info that e.g. the status couldn't be changed
The functionalities are now split up.
do X for issue under cursor
List actions for issue under cursor
QuickUpdate
to list of actionsScreenshot of the partial validation, where the workflow in Redmine forbid changing from In Progress
to Backlog
:
Now I'm ready for comments on error handling :-)
Should be good to go now :-)
LGTM 👍
Hi,
thanks for your awesome plugin!
I've added a functionality which lets you do a "bulk update" of an issue, where the issue id is selected via cursor.
This way I can use it from within my TODO list.
Lets say I have the following issue:
I can now update the issue (status, assignee, write a comment) within one step:
I couldn't really decide on how to name it, if you'd like to have a different name I'll do it :-)