Both additionalHeaders and rejectUnauthorized options are not respected by the extension.
Steps to reproduce:
Set redmine.additionalHeaders to {"Authorization": "Anything"}
Set redmine.url to any webserver address, which can intercept headers (e.g. Burp Suite)
Run Redmine: List open issues assigned to me
Expected results
Request headers should include Authorization: Anything.
Actual results
No header Authorization is found in the request headers.
Note for new-commers
Creating new instance of RedmineServer does not include additionalHeaders and rejectUnauthorized from configuration. One needs to additionally parse and pass these options into the new instances. These are created in src/extension.ts, src/trees/my-issues-tree.ts and src/trees/projects-tree.ts:
Both
additionalHeaders
andrejectUnauthorized
options are not respected by the extension.Steps to reproduce:
redmine.additionalHeaders
to{"Authorization": "Anything"}
redmine.url
to any webserver address, which can intercept headers (e.g. Burp Suite)Redmine: List open issues assigned to me
Expected results
Request headers should include
Authorization: Anything
.Actual results
No header
Authorization
is found in the request headers.Note for new-commers
Creating new instance of
RedmineServer
does not includeadditionalHeaders
andrejectUnauthorized
from configuration. One needs to additionally parse and pass these options into the new instances. These are created insrc/extension.ts
,src/trees/my-issues-tree.ts
andsrc/trees/projects-tree.ts
:https://github.com/rozpuszczalny/vscode-redmine/blob/cbf738d673453cd367ff440860790711476393c6/src/trees/projects-tree.ts#L11-L18
https://github.com/rozpuszczalny/vscode-redmine/blob/cbf738d673453cd367ff440860790711476393c6/src/trees/my-issues-tree.ts#L9-L15
https://github.com/rozpuszczalny/vscode-redmine/blob/cbf738d673453cd367ff440860790711476393c6/src/extension.ts#L57-L64
Thanks to @saiballo for spotting that!