Closed martinsp closed 5 months ago
Bumped ws2812-pio to 0.8
I'd only request one change (but of course repeated for so many boards :o).
@ithinuel I have made the changes
error: package `embedded-hal-async v1.0.0` cannot be built because it requires rustc 1.75 or newer, while the currently active rustc version is 1.72.0-nightly
I think we need to set MSRV to 1.75, that's also what rp2040-hal uses.
error: package `embedded-hal-async v1.0.0` cannot be built because it requires rustc 1.75 or newer, while the currently active rustc version is 1.72.0-nightly
I think we need to set MSRV to 1.75, that's also what rp2040-hal uses.
Should I do this as part of this PR or this will be dealt separately?
I guess the toolchain version should be aligned in this block https://github.com/rp-rs/rp-hal-boards/blob/6eb85ab5e8c582a3dc8a0d98db840b72e9f44697/.github/workflows/build_and_test.yml#L28 with the one in rp2040-hal
?
Should I do this as part of this PR or this will be dealt separately?
I think it would be easiest to change it in this PR, otherwise you'd have to rebase this PR to get the pipeline fixed.
I guess the toolchain version should be aligned in this block
https://github.com/rp-rs/rp-hal-boards/blob/6eb85ab5e8c582a3dc8a0d98db840b72e9f44697/.github/workflows/build_and_test.yml#L28 with the one in
rp2040-hal
?
Yes, replacing toolchain: nightly-2023-06-27
with toolchain: nightly-2024-01-30
should work.
I tested GitHub action on my fork and had to adjust dependencies for pimoroni-tufty204
board to make udeps
step pass, looks like it was failing on main
branch also
Looks good! Thank you for the patience to address all our comments. This is a huge step forward towards BSP releases based on rp2040-hal 0.10.0.
~Depends on unreleased version of ws2812-pio with rp2040-hal 0.10.0 support~