search

rp-rs / rp-hal-boards

Board Support Packages for RP2040 based PCBs
215 stars 90 forks source link

Expose `defmt` feature from `rp2040-hal` #69

Closed tact1m4n3 closed 6 months ago

tact1m4n3 commented 7 months ago

The rp-pico crate(as well as the others) do not have the defmt feature from rp2040-hal exposed. Perhaps it was forgotten to be added? (I've seen that there is already a similar issue to this one #18, but regarding a different feature)

ithinuel commented 7 months ago

IMHO, if the features is not used in the crate, there’s not really any need to re-export it. Because features are aggregated for each crate, one can enable rp2040-hal/defmt on their crate to enable it. I.E. add a dependency in your crate to rp2040-hal and enable the feature there.