rp-rs / rp2040-pac

A Rust PAC for the RP2040 Microcontroller
145 stars 28 forks source link

Additional registers and fields for USB host support #85

Closed nilclass closed 1 year ago

nilclass commented 1 year ago

Related to https://github.com/rp-rs/rp-hal/pull/660

Changes:

nilclass commented 1 year ago

Does the HOST_POLL_INTERVAL field also apply to epx_control ?

It doesn't seem to be added. If that's expected, I'm happy with the PR.

It's not needed for epx_control. Technically it's also not needed for the "EP*_OUT_CONTROL" registers (which are unused in host mode), but the IN and OUT variants must have the same fields to be turned into an array.

nilclass commented 1 year ago

I've added one more change just now, regarding ADDR_ENDP1-15 (description updated above).

nilclass commented 1 year ago

I left as suggestion to enhance readability of the yaml file (and avoid error prone repetitions).

Nice, applied, that's much better!