Closed nilclass closed 1 year ago
Does the
HOST_POLL_INTERVAL
field also apply to epx_control ?It doesn't seem to be added. If that's expected, I'm happy with the PR.
It's not needed for epx_control. Technically it's also not needed for the "EP*_OUT_CONTROL" registers (which are unused in host mode), but the IN and OUT variants must have the same fields to be turned into an array.
I've added one more change just now, regarding ADDR_ENDP1-15
(description updated above).
I left as suggestion to enhance readability of the yaml file (and avoid error prone repetitions).
Nice, applied, that's much better!
Related to https://github.com/rp-rs/rp-hal/pull/660
Changes:
EPX_CONTROL
register, as a copy of theEP_CONTROL
registers (thanks to @ithinuel for figuring out how to express this!)HOST_POLL_INTERVAL
field to theEP_CONTROL
registers. This field may only be used in host mode. It overlaps with the existingINTERRUPT_ON_STALL
/INTERRUPT_ON_NAK
fields, which must not be used in host mode.ADDR_ENDP1
toADDR_ENDP15
into an array namedHOST_ADDR_ENDP
. These registers are used to set up interrupt pipes. They aren't used in device mode. TheADDR_ENDP
register (without a number) which is also used by the device mode, is not part of the array.