rp-rs / rp235x-pac

A Rust PAC for the RP2350 series of Microcontrollers
22 stars 2 forks source link

Add XipCs1 function #7

Open thejpster opened 1 week ago

thejpster commented 1 week ago

It's FUNCSEL 9

jonathanpallant commented 1 week ago

OK, so the problem is the FuncSel value of 9 does different things depending on the pin. But we've flattened it into one enum to cover all the pins.

image

I guess we could call number 9 CS1_CLOCK_TRACE?

jannic commented 1 week ago

There's already an entry for funcsel 9 in the PAC:

      #[doc = "9: Connect to GPCK peripheral"]
      GPCK = 9,

We can't have multiple variants with the same numeric value, so all we could do is rename this variant.

jonathanpallant commented 1 week ago

Yup

thejpster commented 3 days ago

So I think we just leave this and fix it in the HAL