Closed grlm1 closed 8 months ago
Hi Tim, Thanks a lot for your comments and pointing out the bug (#Cumulative number of events: 22.0 66.0). This will be fixed immediately. We also completely agree that the $eventsPerStage should mean the same for the getSampleSizeObject and getSimulationSurvival object. I guess the best would be to introduce a new variable $cumulativeEventsPerStage to avoid such inconsistencies. And the output should be like the one for dIN_ssr. We will do this for the next release. Again, many thanks for your findings, this is very helpful for us. Kind regards Gernot
Fixed in branch dev/3.5.1
Note: we recommend to use the helper function getParameterName()
to identify the correct field name.
Example:
dIN_ssr |>
getParameterName("Cumulative number of events")
produces "overallEventsPerStage" (and not "eventsPerStage" - we know that this is a little bit inconsistent)
Hello, I have looked into the differences in event reporting between objects generated by getSampleSizeSurvival() and getSimulationSurvival(). My attention was specifically on determining whether the number of events is intended to be understood as cumulative or not. My findings are below, I suspect at least one bug in a summary call. Since those two functions are frequently used together, I would argue that subtle semantic differences between them can easily result in mistakes. Kind regards, Tim