Closed nikwen closed 9 years ago
Thanks Niklas for the pull request - indeed it's a very good idea :-)
Unfortunately I didn't have time yet to review that, but I'm very interested in merging it, I'll do a review as soon as I find 10 minutes
Thanks. :)
Any update?
I'm really, really sorry for the long delay. It works like a charm, and it's a very good idea.
I approve it, and in next days I'll publish to the Ubuntu Store.
Thank you very much for your contribute, and sorry again for the delay.
In the future I promise I'll be faster, if you want to do other improvements :-)
Don't worry. There've been other projects where I had to wait much longer to get my changes merged. Thank you for merging it now. :)
What's about the update? :)
Nothing?
Hi Niklas, sorry, but the scope doesn't work on RTM, and I don't understand why.
This is the log:
scoperunner: unity::ResourceException: Cannot load scope com.ubuntu.developer.rpadovani.discerningduck_discerningduck; tried in the following locations:
/opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/libcom.ubuntu.developer.rpadovani.discerningduck_discerningduck.so
/opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/com.ubuntu.developer.rpadovani.discerningduck_discerningduck.so
/opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/scope.so
Exception history:
Exception #1:
unity::ResourceException: /opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/libcom.ubuntu.developer.rpadovani.discerningduck_discerningduck.so: undefined symbol: _ZNK5unity6scopes9ScopeBase17find_child_scopesEv
Exception #2:
unity::ResourceException: /opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/com.ubuntu.developer.rpadovani.discerningduck_discerningduck.so: cannot open shared object file: No such file or directory
Exception #3:
unity::ResourceException: /opt/click.ubuntu.com/com.ubuntu.developer.rpadovani.discerningduck/0.1.3/discerningduck/scope.so: cannot open shared object file: No such file or directory
RegistryObject::ScopeProcess::kill(): Failed to kill scope: "com.ubuntu.developer.rpadovani.discerningduck_discerningduck"
RegistryObject::ScopeProcess: Scope: "com.ubuntu.developer.rpadovani.discerningduck_discerningduck" closed unexpectedly. Either the process crashed or was killed forcefully.
RegistryObject::ScopeProcess::exec(): kill() failed: No such process
Anyway, I'm a bit doubtful about the scope itself: I think it needs a lot of rework, both the code and the UI, but since I don't have time atm I think I'll unpublish it.
If you are interesting in the development I can give you master access to this branch :-)
Hi Riccardo,
Thank you for your reply.
Did you build this using a 15.04 chroot? That might be the reason why it fails to load on 14.10. If you upload the apk somewhere, I can test it on devel-proposed. Did you the contents of the click package? Another question: Does this happen using the version from the store as well?
Regarding unpublishing it: Even if you aren't happy with its code, the scope works perfectly for me on my (devel-proposed) Nexus 4. I would really miss it and I'm sure others agree with me here. If the reason for unpublishing is the issue on RTM, you could build and upload it using the 15.04 framework, which would kind of unpublish it for all of those who are on the RTM builds while those who are on the devel-proposed builds (where the scope works perfectly) can still install it.
The reason why I sadly can't put more time into it is that I have multiple projects running already, too. If I just had more time...
Indeed it works on vivid. Sigh, SDK makes me crazy. Anyway, vivid it's ~2 weeks far from RTM merging, so I'll publish the update after the merging. I've also an update for 100balls that's waiting :S
About the unpublishing: I'm not happy about features, I had great plans for this scope, but then I didn't find any time.
Anyway, if you're happy with it, that's enough for me, I'll leave it there and hope to develop it more in the future :-)
Great to hear you don't plan to unpublish it. :)
The reason why it doesn't work on 14.10 might be that one needs a 15.04 chroot for building a qmake project. The RTM Unity8 probably doesn't know how to deal with 15.04 scopes... Personally, I wouldn't expect a stable version based on vivid to be pushed out in less than 6 weeks though. However, I agree that it's probably best to wait until then. ;)
May I ask which features you wanted to implement? I'd really love to see new features in Discerning Duck, so I'd be really happy if you find some time to continue working on it. :)
Cheers, Niklas
May I ask which features you wanted to implement?
Unfortunately DDG doesn't expose yet spices, but I want to improve goodies. The first example is when you search a color, I would like to show in the scope an image with that color :-) And a lot of goodies I think could have a bettter visualization, depending on which is the query.
Also, I would like to re write the code, my C++ skills are improved since then (well, going from 0 to 1 is a infinity % improvement :stuck_out_tongue_winking_eye: )
These sound really nice, so be assured that if you ever come to work on this again, I'll be very happy about the new features. :)
Now that OTA 4 is out, would you mind looking into updating the scope again? Thanks. :)
Here we are, thanks again :-)
Thanks for publishing it. :)
Thank you very much for your awesome scope! :smile:
Here's a little adjustment I did which allows to search directly on DDG if no results could be found. Do you like the modified label text or should we change it?