search

rpaschoal / ng-chat

💬 A simple facebook/linkedin lookalike chat module for Angular applications.
MIT License
155 stars 92 forks source link

In SignalR demo issue with userId when uploading files #124

Closed MuhammadRizwanBashir closed 5 years ago

MuhammadRizwanBashir commented 5 years ago

I was checking SignalR demo and uploaded files to someone in chat room. once i uploaded file to one user and then uploaded file to other user, but file sent to same user whom i sent before. Maybe i have changed the focus, or on upload button userId is not changing. I haven't debugged yet. Maybe this is issue in just demo. I will update here after implementation.

MuhammadRizwanBashir commented 5 years ago

File only can be send to user we sent first, to send file to other user we have to close the chat window of previous user we have sent the file. There is issue in file upload.

rpaschoal commented 5 years ago

Hi @MuhammadRizwanBashir ,

Thank you for reporting this issue.

I'll investigate and if this is really a problem will come up with a patch release at some point this week.

Cheers!

rpaschoal commented 5 years ago

Hi @MuhammadRizwanBashir ,

Just letting you know that a fix for this issue has just been published to NPM with version 2.0.4.

This is the pull request containing the changes #125 and here you can find the details of what was released with version 2.0.4: https://github.com/rpaschoal/ng-chat/releases/tag/2.0.4

MuhammadRizwanBashir commented 5 years ago

@rpaschoal Thanks! Appreciated.