search

rpaschoal / ng-chat

💬 A simple facebook/linkedin lookalike chat module for Angular applications.
MIT License
155 stars 92 forks source link

Pagination for history messages #69

Closed rmussabayev closed 5 years ago

rmussabayev commented 6 years ago

Changed ScrollDirection enum values to camel case and set hasMoreMessages parameter to false by default

codecov[bot] commented 6 years ago

Codecov Report

Merging #69 into development will decrease coverage by 1.08%. The diff coverage is 55.55%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #69      +/-   ##
===============================================
- Coverage        76.65%   75.57%   -1.09%     
===============================================
  Files               10       11       +1     
  Lines              424      438      +14     
  Branches            81       82       +1     
===============================================
+ Hits               325      331       +6     
- Misses              68       74       +6     
- Partials            31       33       +2
Impacted Files Coverage Δ
src/ng-chat/core/scroll-direction.enum.ts 100% <100%> (ø)
src/ng-chat/core/chat-adapter.ts 72.22% <100%> (-7.78%) :arrow_down:
src/ng-chat/core/window.ts 100% <100%> (ø) :arrow_up:
src/ng-chat/ng-chat.component.ts 71.25% <33.33%> (-1.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aeb2f6...a75815b. Read the comment docs.

rpaschoal commented 5 years ago

@rmussabayev I am merging this to another branch so I can test it and do some changes around the adapter.