Closed rpaschoal closed 5 years ago
@rmussabayev Could you please review these changes and perform a smoke test on it too?
In case you don't want to setup the backend you can use this: https://github.com/rpaschoal/ng-chat-nodejs
You will need to add this @Input value to the ng-chat instance in order to test the upload of files (In case you decide to use the nodejs sample) [fileUploadUrl]="'http://localhost:3000/uploadFile'"
I did some smoke test around this, if you are quite busy recently a code review would be enough. Cheers and thank you :)
Merging #78 into 1.1.0 will increase coverage by
0.2%
. The diff coverage is74.57%
.
@@ Coverage Diff @@
## 1.1.0 #78 +/- ##
=========================================
+ Coverage 76.65% 76.85% +0.2%
=========================================
Files 10 15 +5
Lines 424 540 +116
Branches 81 98 +17
=========================================
+ Hits 325 415 +90
- Misses 68 89 +21
- Partials 31 36 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/ng-chat/core/window.ts | 100% <ø> (ø) |
:arrow_up: |
src/ng-chat/core/chat-adapter.ts | 80% <ø> (ø) |
:arrow_up: |
src/ng-chat/core/default-file-upload-adapter.ts | 100% <100%> (ø) |
|
src/ng-chat/core/message.ts | 100% <100%> (ø) |
:arrow_up: |
src/ng-chat/core/message-type.enum.ts | 100% <100%> (ø) |
|
src/ng-chat/core/scroll-direction.enum.ts | 100% <100%> (ø) |
|
src/ng-chat/core/paged-history-chat-adapter.ts | 66.66% <60%> (ø) |
|
src/ng-chat/core/file-message.ts | 78.94% <66.66%> (ø) |
|
src/ng-chat/ng-chat.component.ts | 72.46% <72.15%> (-0.4%) |
:arrow_down: |
... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6aeb2f6...c7ed998. Read the comment docs.
What's included in these changes: