search

rpattabi / diskpacker

Automatically exported from code.google.com/p/diskpacker
0 stars 0 forks source link

Refactoring of the existing code is required #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. The code is not organized well. Everything is in a single file.
2. The design shall be re looked at. The type of bin (CD/DVD/etc), and the
type of compilation output shall be easily pluggable and selectable.
3. Tests???

Original issue reported on code.google.com by ananth.p...@gmail.com on 17 May 2008 at 5:58

GoogleCodeExporter commented 9 years ago 
4. The input paths file shall be taken as command line argument. Currently it 
is hard
coded.
5. CD/DVD label is hard coded to DIVXMOVIES. Default could be BKP_#. There 
could be
an optional command line argument which overrides this. Better is to provide
formatting options to the user, something like MOVIES_[DATE]_[ID]

Original comment by ananth.p...@gmail.com on 17 May 2008 at 6:04

GoogleCodeExporter commented 9 years ago 
1st bullet is done. See revision 4.

Original comment by ragunath...@gmail.com on 23 May 2008 at 6:07

GoogleCodeExporter commented 9 years ago 
Updated bin creation done with a simple factory. This marginally improved the 
design.
Gotten rid of the ugly clone method in Bin. The bin packer now uses this simple
factory. See revision 5.

Original comment by ragunath...@gmail.com on 24 May 2008 at 6:32

GoogleCodeExporter commented 9 years ago 
Plenty of refactorings, test suites, etc are done. Still there is plenty of 
scope for
improvement. See revision through 12.

Original comment by ragunath...@gmail.com on 26 May 2008 at 9:19

GoogleCodeExporter commented 9 years ago 
Quite a few updates are done. Closing this item. See revision 13.

Original comment by ragunath...@gmail.com on 26 May 2008 at 2:41

GoogleCodeExporter commented 9 years ago 
Quite a few updates are done. Closing this item. See revision 13.

Original comment by ragunath...@gmail.com on 26 May 2008 at 2:42