search

rpau / javalang-compiler

Java compiler elements (symbol and type tables) to perform code semantic analysis
GNU Lesser General Public License v3.0
10 stars 4 forks source link

insufficient semantic test (Maybe in SymbolType.isCompatible?) #31

Closed cal101 closed 7 years ago

cal101 commented 7 years ago

I don't think the real problem of SymbolType.isCompatible was solved with the solution to https://github.com/rpau/javalang-compiler/issues/30. For generic cases the method is skipping most of it's code. See https://github.com/rpau/javalang-compiler/pull/32 If the style of the test change is OK for you (I didn't want to duplicate too much code) I can change more test cases to positive/negative cases. Or do I completely miss something?

cal101 commented 7 years ago

As discussed in #30 the new test case is wrong because it won't compile. What I missed is that only compilable code is checked. So my change should be reverted. I take a look later if I find missing compilable cases. Thanks for looking into it and sorry for the confusion.

cal101 commented 7 years ago

I removed my wrong test case and added a failing one. See https://github.com/rpau/javalang-compiler/pull/33

cal101 commented 7 years ago

Issue is cared for in more specific other tickets.