ASM integration in TypesLoaderVisitor

rpau / javalang-compiler

Java compiler elements (symbol and type tables) to perform code semantic analysis

GNU Lesser General Public License v3.0

10 stars 4 forks source link

ASM integration in TypesLoaderVisitor #86

Open rpau opened 6 years ago

rpau commented 6 years ago

This patch replaces reflection by ASM and increases the performace almost a 20%. ASM parses binary files and allows to extract the minimum amount of information that is required to analyze.

coveralls commented 6 years ago

Coverage increased (+0.08%) to 86.127% when pulling 49c6e2a852ddc3201efc40140776cdebf281d70e on rpau-asm into d7da81359161feef2bc7ff186c4e1b73c6a5a8ef on master.

rpau commented 6 years ago

requests addressed

rpau commented 6 years ago

ping @cal101

cal101 commented 6 years ago

Moin Raquel!

How are you! I am not sure what you want me to do?
There is atleast wrong usage of File.separator in asmclass which will fail only on non unix but nevertheless ... Style or separation issues can be put aside.

octopatch commented 5 years ago

@rpau remember that you have a pending review request