rpautrat / SuperPoint

Efficient neural feature detector and descriptor
MIT License
1.88k stars 416 forks source link

add os.environ['CUDA_VISIBLE_DEVICES'] = 0 in experiments.py #248

Closed Gpetrak closed 2 years ago

Gpetrak commented 2 years ago

Hello and congrats for this amazing project. I modified the following code, because I had issues in the training process. Now it works like a charm.

rpautrat commented 2 years ago

Hi, thanks for reporting your changes and submitting the PR!

Hard-coding 'CUDA_VISIBLE_DEVICES' to 0 would disable the possibility to run multi GPU training, so I cannot accept it.

Regarding the other changes, their are specific to your system and ROS users, so I'd rather keep the current code as generic as possible and not include it. Otherwise we would have to handle cases for anaconda users, for ROS ones, etc.

So I'll close this PR for now, but you could instead fill an issue with your experience, so that other users of ROS or who are having trouble with the GPU can do the changes themselves locally.

Gpetrak commented 2 years ago

Τhank you for the quick response.

It's absolutely understandable to not accept the PL. I'll open an issue with my changes in the code as soon as possible.

Στις Σάβ 26 Φεβ 2022 στις 1:22 μ.μ., ο/η Rémi Pautrat < @.***> έγραψε:

Closed #248 https://github.com/rpautrat/SuperPoint/pull/248.

— Reply to this email directly, view it on GitHub https://github.com/rpautrat/SuperPoint/pull/248#event-6144996596, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ2XPGGPW54PGFYMYDDWHLU5CZWJANCNFSM5PMPWL7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Georgios Petrakis Geo-informatics Engineer MSc Phd Candidate, Technical University of Crete

Γεώργιος Πετράκης Αγρ & Τοπογράφος Μηχανικός ΕΜΠ, MSc Υπ. Διδάκτωρ, Πολυτεχνείο Κρήτης Πλ. Ελευθερίας 29Α (Μέγαρο Ντορέ) Τηλ: 2810-288363 Κιν: 6984871889