search

rpavlik / vrjuggler

My VR Juggler changes, including a cmake-based build
http://academic.cleardefinition.com
GNU Lesser General Public License v2.1
4 stars 6 forks source link

Revised cmake 3.0 #7

Open nixz opened 11 years ago

nixz commented 11 years ago

Hi Ryan,

I pushed a few CMake changes to CMakeLists.txt to enable using VRJugglerConfig.cmake. This means that external projects can do a find_package(VRJuggler) without having a FindVRJuggler.cmake file. Simply pointing the VRJuggler_DIR to the directory containing VRJugglerConfig.cmake brings in the environment needed by any external cmake based project.

-Nikhil

rpavlik commented 10 years ago

Sorry I didn't see this - Github's notification system is all messed up. I don't think you actually need to put the variables in the cache to get them into the configured file. Also, I'd rather not change the "super-project"'s project name unless it's needed, since it can be confusing and I'm not sure if there is an issue with having project called twice with basically the same (or the same) name.

This is great work, though! Looking forward to merging or cherrypicking.